Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov config and update readme badges #894

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

oddstr13
Copy link
Member

@oddstr13 oddstr13 commented Jul 22, 2024

This Codecov config should stop coverage from failing PRs, while still showing the information.

Readme

  • Add badges for
    • Codecov Code coverage
    • CodeQL CodeQL Analysis
  • Remove whitespace from inside badge a-tag content.
    This makes the readme render nicer (removes single space underlined link between badges), at the cost of code quality/maintainability.
    One alternative would be to move the whitespace into the tags themselves, but that is also not clean.

Readme preview

@oddstr13 oddstr13 added the ci label Jul 22, 2024
Copy link

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.50%. Comparing base (62a1de7) to head (a8982d2).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   21.50%   21.50%           
=======================================
  Files          63       63           
  Lines        8632     8632           
  Branches     1585     1585           
=======================================
  Hits         1856     1856           
  Misses       6755     6755           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddstr13 oddstr13 merged commit 51528e9 into jellyfin:master Jul 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant