Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AV1 as a preferred codec option #892

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

Insprill
Copy link
Contributor

@Insprill Insprill commented Jul 22, 2024

This adds AV1 as an option for the preferred codec in addition to H264/5, and allows it to be used as a last-resort if other formats are unavailable. This could be considered a follow-up to #545, since it only allowed AV1 to be direct-played, not transcoded.

@Insprill Insprill marked this pull request as draft July 22, 2024 04:10
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.90%. Comparing base (9eb9cd1) to head (9fa102e).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   21.86%   21.90%   +0.03%     
==========================================
  Files          63       63              
  Lines        8630     8634       +4     
  Branches     1585     1587       +2     
==========================================
+ Hits         1887     1891       +4     
+ Misses       6724     6722       -2     
- Partials       19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddstr13
Copy link
Member

Don't mind the code coverage report, adding tests for most things in this project is difficult.

@oddstr13 oddstr13 added needs-testing Some testing is requested/required before merging merge conflict labels Aug 9, 2024
Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase due to the HEVC PR touching the same file region.
That same PR added tests covering this function, so those tests need updating to account for the changes here.

jellyfin_kodi/helper/playutils.py Outdated Show resolved Hide resolved
@Insprill Insprill force-pushed the feature/transcode-av1 branch from 900cb00 to f404838 Compare August 10, 2024 21:21
Copy link

@Insprill Insprill marked this pull request as ready for review August 10, 2024 21:45
Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just need to find a way to test if it actually works

@oddstr13
Copy link
Member

It works? Probably, sort of?
My server was screaming bloody murder, and my Kodi client didn't wanna play the video, only audio (I'm stuck on Kodi 20).

So, this PR works, after enabling AV1 transcoding on the server, but it doesn't actually work for me.

I tested by setting AV1 as the preferred codec, and enabling transcode HEVC.

@oddstr13 oddstr13 changed the title Add AV1 as a preferred codec Add AV1 as a preferred codec option Aug 11, 2024
@oddstr13 oddstr13 added enhancement New feature or request and removed needs-testing Some testing is requested/required before merging labels Aug 11, 2024
@oddstr13 oddstr13 merged commit fc1bcb3 into jellyfin:master Aug 11, 2024
12 checks passed
@Insprill Insprill deleted the feature/transcode-av1 branch August 13, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants