-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AV1 as a preferred codec option #892
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
==========================================
+ Coverage 21.86% 21.90% +0.03%
==========================================
Files 63 63
Lines 8630 8634 +4
Branches 1585 1587 +2
==========================================
+ Hits 1887 1891 +4
+ Misses 6724 6722 -2
- Partials 19 21 +2 ☔ View full report in Codecov by Sentry. |
Don't mind the code coverage report, adding tests for most things in this project is difficult. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase due to the HEVC PR touching the same file region.
That same PR added tests covering this function, so those tests need updating to account for the changes here.
900cb00
to
f404838
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just need to find a way to test if it actually works
It works? Probably, sort of? So, this PR works, after enabling AV1 transcoding on the server, but it doesn't actually work for me. I tested by setting AV1 as the preferred codec, and enabling transcode HEVC. |
This adds AV1 as an option for the preferred codec in addition to H264/5, and allows it to be used as a last-resort if other formats are unavailable. This could be considered a follow-up to #545, since it only allowed AV1 to be direct-played, not transcoded.