Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function compare_version #874

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

oddstr13
Copy link
Member

@oddstr13 oddstr13 commented Jun 10, 2024

Closes #864
The usage of distutils here may be causing issues with py3.12 – not showing up in our tests tho.

@oddstr13 oddstr13 added the cleanup Non-functional code cleanup/readability/formatting label Jun 10, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.48%. Comparing base (91b35cb) to head (4a1ac6d).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   21.49%   21.48%   -0.01%     
==========================================
  Files          63       63              
  Lines        8638     8628      -10     
  Branches     1589     1587       -2     
==========================================
- Hits         1857     1854       -3     
+ Misses       6757     6750       -7     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddstr13 oddstr13 merged commit f4ffe69 into jellyfin:master Jun 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional code cleanup/readability/formatting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant