Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear playlist if clear flag is set (UpNext) #871

Merged

Conversation

CeruleanRed
Copy link
Contributor

@CeruleanRed CeruleanRed commented Jun 5, 2024

  • Specifically continue to play the playlist at the insertion index
  • Remove what seems to be a left over commented out section

Fixes issues with up next plugin where the popup would not show up after the first episode. Tested with Kodi v21 and jf4k 1.0.3 on Windows 11.

Fixes #717

- Specifically continue to play the playlist at the insertion index
- Remove what seems to be a left over commented out section
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 21.49%. Comparing base (1899ecb) to head (91b35cb).
Report is 9 commits behind head on master.

Files Patch % Lines
jellyfin_kodi/objects/actions.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   21.51%   21.49%   -0.02%     
==========================================
  Files          63       63              
  Lines        8632     8638       +6     
  Branches     1589     1589              
==========================================
  Hits         1857     1857              
- Misses       6751     6757       +6     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddstr13 oddstr13 added the bugfix label Jun 7, 2024
@oddstr13 oddstr13 changed the title fix: clear playlist if clear flag is set Clear playlist if clear flag is set (UpNext) Jun 7, 2024
@oddstr13
Copy link
Member

oddstr13 commented Jun 7, 2024

I don't immediately see any issues, but I'll run it a bit to test.

The commented out line came from the emby version, and has never been uncommented in jf4kodi

Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems working to me, thanks for the fix!

@oddstr13 oddstr13 merged commit f209f9e into jellyfin:master Jun 8, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Up Next + Jellyfin server
2 participants