Run the black formatter #869
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
=======================================
Coverage 21.48% 21.48%
=======================================
Files 63 63
Lines 8628 8628
Branches 1587 1587
=======================================
Hits 1854 1854
Misses 6750 6750
Partials 24 24 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if server['Id'] == new_credentials['Servers'][0]['Id']: | ||
| server = new_credentials['Servers'][0] | ||
| if server["Id"] == new_credentials["Servers"][0]["Id"]: | ||
| server = new_credentials["Servers"][0] |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
|
||
| def select_servers(self, state=None): | ||
|
|
||
| state = state or self.connect_manager.connect({'enableAutoLogin': False}) | ||
| state = state or self.connect_manager.connect({"enableAutoLogin": False}) |
Check notice
Code scanning / CodeQL
Unused local variable Note
| for song in self.jellyfin_db.get_item_by_parent_id( | ||
| *values(obj, QUEM.get_item_by_parent_song_obj) | ||
| ): |
Check warning
Code scanning / CodeQL
Unnecessary 'else' clause in loop Warning
| for album in self.jellyfin_db.get_item_by_parent_id( | ||
| *values(obj, QUEM.get_item_by_parent_album_obj) | ||
| ): |
Check warning
Code scanning / CodeQL
Unnecessary 'else' clause in loop Warning
| for song in self.jellyfin_db.get_item_by_parent_id( | ||
| *values(temp_obj, QUEM.get_item_by_parent_song_obj) | ||
| ): |
Check warning
Code scanning / CodeQL
Unnecessary 'else' clause in loop Warning
|
|
||
| # Remove any series pooling episodes | ||
| for episode in self.jellyfin_db.get_media_by_parent_id(obj['Id']): | ||
| self.remove_episode(episode[2], episode[3], obj['Id']) | ||
| for episode in self.jellyfin_db.get_media_by_parent_id(obj["Id"]): |
Check warning
Code scanning / CodeQL
Unnecessary 'else' clause in loop Warning
| on_error=lambda ws, error: self.on_error(ws, error)) | ||
| self.wsc = websocket.WebSocketApp( | ||
| wsc_url, | ||
| on_open=lambda ws: self.on_open(ws), |
Check notice
Code scanning / CodeQL
Unnecessary lambda Note
| self.wsc = websocket.WebSocketApp( | ||
| wsc_url, | ||
| on_open=lambda ws: self.on_open(ws), | ||
| on_message=lambda ws, message: self.on_message(ws, message), |
Check notice
Code scanning / CodeQL
Unnecessary lambda Note
| wsc_url, | ||
| on_open=lambda ws: self.on_open(ws), | ||
| on_message=lambda ws, message: self.on_message(ws, message), | ||
| on_error=lambda ws, error: self.on_error(ws, error), |
Check notice
Code scanning / CodeQL
Unnecessary lambda Note
There was a problem hiding this comment.
intentional to work around issue in the websocket library. may or may not still be needed, but shouldn't hurt anything except using a stack frame extra
| "artwork", | ||
| "title", | ||
| "content", | ||
| "type" "inprogress.content", |
Check warning
Code scanning / CodeQL
Implicit string concatenation in a list Warning
|
Might be worth going thru the CodeQL and SonarCloud warnings thrown here, but none of them are new for this PR, as it provides no functional changes. |
oddstr13
force-pushed
the
black
branch
3 times, most recently
from
ef5628a to
781b2c2
Compare
|
The changes in this PR are made by running the
run_black.shfrom #868The .git-blame-ignore-revs allow git blame to stay useful even after massive formatting changes such as this.