Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix movie database for Kodi 21 #831

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

AmonFlorian
Copy link
Contributor

Fixes movieview from Kodi 21 beta3 (videoversion implementation).
Compatible to versions w/o this feature (Kodi 20.4 tested).

Known issues:
Movies are added as "Standard Edition" no matter their real edition.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mcarlton00
Copy link
Member

Finally managed to track down one of my Pis and got LibreElec nightly installed onto it. This does indeed fix it for all new stuff added to the database the fix has been applied. However, it does require a "repair database" to fix old entries. Therefore, we have two options:

  • Detect the update, trigger a repair database on the movies library (painful for users)
  • Detect the update, perform a database migration to update old entries (painful for us)

I'll need to think more on that, it'll probably happen in a separate PR, but I'll leave this open for the moment in case @oddstr13 has opinions

@mcarlton00 mcarlton00 merged commit 42d1c53 into jellyfin:master Mar 7, 2024
9 checks passed
@oddstr13
Copy link
Member

oddstr13 commented Mar 7, 2024

Still syncs episodes for me in Kodi 20.2, so that is sufficient for me.

@oddstr13 oddstr13 changed the title Quick and dirty movie_view fix. Fix movie database for Kodi 21 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants