Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations and mypy #821

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Make mypy happier

49f6546
Select commit
Loading
Failed to load commit list.
Draft

Type annotations and mypy #821

Make mypy happier
49f6546
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 22, 2024 in 0s

21.80% (+0.27%) compared to e234fb4

View this Pull Request on Codecov

21.80% (+0.27%) compared to e234fb4

Details

Codecov Report

Attention: Patch coverage is 53.04348% with 54 lines in your changes missing coverage. Please review.

Project coverage is 21.80%. Comparing base (e234fb4) to head (49f6546).
Report is 177 commits behind head on master.

Files Patch % Lines
jellyfin_kodi/entrypoint/service.py 18.18% 9 Missing ⚠️
jellyfin_kodi/library.py 50.00% 8 Missing ⚠️
jellyfin_kodi/monitor.py 22.22% 7 Missing ⚠️
jellyfin_kodi/connect.py 25.00% 6 Missing ⚠️
jellyfin_kodi/helper/utils.py 50.00% 4 Missing ⚠️
jellyfin_kodi/views.py 0.00% 3 Missing ⚠️
jellyfin_kodi/client.py 33.33% 2 Missing ⚠️
jellyfin_kodi/dialogs/context.py 60.00% 2 Missing ⚠️
jellyfin_kodi/entrypoint/default.py 0.00% 2 Missing ⚠️
jellyfin_kodi/helper/wrapper.py 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
+ Coverage   21.52%   21.80%   +0.27%     
==========================================
  Files          63       63              
  Lines        8537     8570      +33     
  Branches     1571     1574       +3     
==========================================
+ Hits         1838     1869      +31     
  Misses       6675     6675              
- Partials       24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.