Fix convert_to_local tests on Windows #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
=======================================
Coverage 21.51% 21.51%
=======================================
Files 63 63
Lines 8542 8542
Branches 1572 1572
=======================================
Hits 1838 1838
+ Misses 6682 6680 -2
- Partials 22 24 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oddstr13
force-pushed
the
pr-pytest-timezone-windows-1
branch
from
3c4a9f2 to
8dbf503
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been unable to find any tzset equivalent for Windows.
The closest I got was this stackoverflow answer from 2011, but it is 10 years outdated, code no longer runs (errors on the
msvcrt.ctime), and suggests recompiling Python with specific preprocessor flags is required.https://stackoverflow.com/a/6972586/1035647