Update utils.py #756
Update utils.py #756
Conversation
removed use of astimezone because it throws an error for times before the epoch
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
This implementation is naive, and does not take into account that the UTC offset can change.
https://www.youtube.com/watch?v=-5wpm-gesOY
I've added tests for this now, but I haven't managed to get windows CI working (at all, nor with changing timezones for testing), so I don't really have any way of testing alternative solutions for windows.
I would very much like for this timezone calculation to happen in a standard library, and not be implemented in the addon code, as it is as good as impossible to get it right, and keep it right. Please see the linked YouTube video for inspiration for staying away from time code (shudder).
It is tempting to simply return the UTC timestamp for dates below epoch, but I haven't decided if that's a good idea yet.
Hello,
removed use of astimezone because it throws an error for times before the epoch on windows platforms and replaced it with timezone and timedelta functions instead
Reference Issue
#725