Skip to content

Commit

Permalink
Merge pull request #881 from oddstr13/pr-vscode-devcontainer-1
Browse files Browse the repository at this point in the history
Update devcontainer and vscode config
  • Loading branch information
oddstr13 authored Jun 12, 2024
2 parents 9cdc027 + 62a1de7 commit b6319e1
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/python
{
"name": "Python 3.11",
"name": "Python",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/python:1-3.11-bookworm",

"image": "mcr.microsoft.com/devcontainers/python:1-3.12-bookworm",
// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "pip3 install --user -r requirements-dev.txt",

// Configure tool-specific properties.
"customizations": {
"vscode": {
Expand All @@ -23,12 +19,12 @@
"GitHub.vscode-pull-request-github",
"hbenl.vscode-test-explorer",
"redhat.vscode-xml",
"ninoseki.vscode-pylens",
"ms-python.black-formatter"
"ninoseki.vscode-mogami",
"ms-python.black-formatter",
"ms-python.flake8"
]
}
}

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
9 changes: 5 additions & 4 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
{
"editor.formatOnSave": true,
"python.formatting.provider": "black",
"python.linting.enabled": true,
"python.linting.flake8Enabled": true,
"python.linting.mypyEnabled": true,
"python.testing.pytestEnabled": true,
"python.analysis.diagnosticMode": "workspace",
"files.associations": {
Expand All @@ -13,4 +9,9 @@
"connectionId": "jellyfin",
"projectKey": "jellyfin_jellyfin-kodi"
},
"[python]": {
"editor.defaultFormatter": "ms-python.black-formatter"
},
"flake8.importStrategy": "fromEnvironment",
"black-formatter.importStrategy": "fromEnvironment",
}
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ coverage >= 5.2
flake8 >= 3.8
flake8-import-order >= 0.18
websocket-client >= 1.6.4
black >= 24.4.2

types-requests >= 2.31
types-PyYAML >= 6.0
Expand Down

0 comments on commit b6319e1

Please sign in to comment.