-
-
Notifications
You must be signed in to change notification settings - Fork 134
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lavc/videotoolbox: remove opengl compatability key
We are not using OpenGL and this compatability key could introduce performance penalty on some Macs. Performance difference is neglible on Apple Silicon but on old Intel Macs like the 2018 MacBook Air, decoding performance could be reduced by 15% as the IOSurface might make extra frame copies to reshape the pixel buffer.
- Loading branch information
Showing
2 changed files
with
17 additions
and
0 deletions.
There are no files selected for viewing
16 changes: 16 additions & 0 deletions
16
debian/patches/0079-videotoolbox-remove-opengl-compatability.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Index: FFmpeg/libavcodec/videotoolbox.c | ||
=================================================================== | ||
--- FFmpeg.orig/libavcodec/videotoolbox.c | ||
+++ FFmpeg/libavcodec/videotoolbox.c | ||
@@ -786,11 +786,6 @@ static CFDictionaryRef videotoolbox_buff | ||
CFDictionarySetValue(buffer_attributes, kCVPixelBufferIOSurfacePropertiesKey, io_surface_properties); | ||
CFDictionarySetValue(buffer_attributes, kCVPixelBufferWidthKey, w); | ||
CFDictionarySetValue(buffer_attributes, kCVPixelBufferHeightKey, h); | ||
-#if TARGET_OS_IPHONE | ||
- CFDictionarySetValue(buffer_attributes, kCVPixelBufferOpenGLESCompatibilityKey, kCFBooleanTrue); | ||
-#else | ||
- CFDictionarySetValue(buffer_attributes, kCVPixelBufferIOSurfaceOpenGLTextureCompatibilityKey, kCFBooleanTrue); | ||
-#endif | ||
|
||
CFRelease(io_surface_properties); | ||
CFRelease(cv_pix_fmt); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters