Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mobx to zustand #583

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
ff637a0
Install zustand
enigma0Z Dec 10, 2024
aeca337
Convert root store to typescript & zustand
enigma0Z Dec 10, 2024
f9e09bd
Reference new zustand root store
enigma0Z Dec 10, 2024
b362a19
Fix test to work with hooks
enigma0Z Dec 10, 2024
90850f2
Add react testing library & jest-environment-jsdom
enigma0Z Dec 10, 2024
6c1891f
Make root store test more concise
enigma0Z Dec 10, 2024
5da37f1
Port DownloadStore/DownloadModel to zustand
enigma0Z Dec 10, 2024
89c8e64
Remove commented-out code
enigma0Z Dec 10, 2024
da8f22c
Remove commented-out code
enigma0Z Dec 10, 2024
6ab000e
Remove commented-out code
enigma0Z Dec 10, 2024
f9b41d1
Convert ServerModel and ServerStore to zustand
enigma0Z Dec 10, 2024
8f2ff18
Remove commented-out code
enigma0Z Dec 10, 2024
17e18fb
Fix broken tests/refs with refactor of mediastore
enigma0Z Dec 10, 2024
a4bc5ed
Convert setting store to TS
enigma0Z Dec 10, 2024
73c4790
Convert settingstore to use zustand
enigma0Z Dec 10, 2024
889dd5e
Remove usage of mobx observer
enigma0Z Dec 10, 2024
9a1c05a
Remove mobx action implementations
enigma0Z Dec 11, 2024
0e18e16
Remove mobx action implementations
enigma0Z Dec 11, 2024
bc387f4
Remove mobx action implementations
enigma0Z Dec 11, 2024
da56ce7
Add generic setter function for the stores that need it, convert all …
enigma0Z Dec 11, 2024
5cb35f0
Conver setting store to use setters
enigma0Z Dec 11, 2024
0ccf45c
Update rootStore setters
enigma0Z Dec 11, 2024
1e5bbea
Update mediastore to use setters
enigma0Z Dec 11, 2024
e8bd175
Reset all stores correctly since rootStore.reset() was refactored
enigma0Z Dec 11, 2024
b2a88e4
Fix render loop with using a set state on app initialization
enigma0Z Dec 11, 2024
163010e
Persist zustand storage, migrate mobx stores
enigma0Z Dec 11, 2024
23722c2
Fix refresh web view (which I broke trying to get tests working)
enigma0Z Dec 11, 2024
2efecc2
Remove usage of async trunk
enigma0Z Dec 11, 2024
00a4abf
Restore docstrings on root store
enigma0Z Dec 11, 2024
bf86687
Fix serializer tests
enigma0Z Dec 11, 2024
7ec4391
Fix warnings
enigma0Z Dec 11, 2024
d7825a6
Update tests to use setters
enigma0Z Dec 11, 2024
c0b1533
Merge remote-tracking branch 'upstream/master' into feature/migrate-m…
enigma0Z Dec 11, 2024
c8184ce
Remove mobx packages
enigma0Z Dec 11, 2024
32fad17
Linter fixups
enigma0Z Dec 11, 2024
8d8ed65
Clear eslint whitespace errors
enigma0Z Dec 11, 2024
789b378
Ignore eslint import error (I suspect an outdated version of react na…
enigma0Z Dec 11, 2024
209a2ac
Tag the silly eslint import error with the issue it's tracked under.
enigma0Z Dec 12, 2024
2bc2bba
Merge branch 'master' into feature/migrate-mobx-to-zustand
enigma0Z Dec 13, 2024
3741378
Merge branch 'master' into feature/migrate-mobx-to-zustand
enigma0Z Dec 19, 2024
9d7f219
Merge branch 'master' into feature/migrate-mobx-to-zustand
enigma0Z Jan 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tag the silly eslint import error with the issue it's tracked under.
  • Loading branch information
enigma0Z committed Dec 12, 2024
commit 209a2ac2b0305b9e22a9be7abae3ba071fddb37b
6 changes: 1 addition & 5 deletions stores/SettingStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import AsyncStorage from '@react-native-async-storage/async-storage';
import compareVersions from 'compare-versions';

// TODO: Fix this import
// Eslint was complaining about this import, maybe because it's coming from
// an outdated module? In any case, I think updating stuff is out of scope
// for the PR in which this is being added.

// TODO: Fix this import, this is a bandaid; issue #365
// eslint-disable-next-line import/namespace
import { Platform } from 'react-native';
enigma0Z marked this conversation as resolved.
Show resolved Hide resolved

Expand Down Expand Up @@ -57,7 +53,7 @@

type Actions = {
set: (v: Partial<State>) => void,
getTheme: () => any, // TODO: get typing on themes and put it here

Check warning on line 56 in stores/SettingStore.ts

View workflow job for this annotation

GitHub Actions / Lint

Unexpected any. Specify a different type

Check warning on line 56 in stores/SettingStore.ts

View workflow job for this annotation

GitHub Actions / Lint

Unexpected any. Specify a different type
reset: () => void
}

Expand Down
Loading