Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Expo 46 version #543

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Nov 8, 2024

To regenerate the ios directory:

  • rm -rf ios
  • npm run ios
  • You will see a build error if using xcode 15
  • git apply patches/xcode15.patch
  • npm run ios
  • The ios directory should be successfully regenerated and the project launched in a device simulator

I do see a runtime error in metro about an unresolved dependency for the ios date picker component, but it doesn't seem to cause any actual issues. I will investigate fixing the warning in a subsequent PR.
Fixed in #547

@thornbill thornbill added the build This PR or issue mainly concerns build tools label Nov 8, 2024
@thornbill thornbill added this to the v1.6.0 milestone Nov 8, 2024
Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.10%. Comparing base (f206aa5) to head (af81d96).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   60.21%   60.10%   -0.11%     
==========================================
  Files          46       47       +1     
  Lines         945      945              
  Branches      189      185       -4     
==========================================
- Hits          569      568       -1     
- Misses        341      342       +1     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thornbill thornbill merged commit b628b5e into jellyfin:master Nov 8, 2024
8 checks passed
@thornbill thornbill deleted the bump-expo-46 branch November 8, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This PR or issue mainly concerns build tools
Development

Successfully merging this pull request may close these issues.

2 participants