Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unavailable Expo version #541

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Remove unavailable Expo version #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fadd9b
Remove unavailable expo version
thornbill Nov 7, 2024
2aa6dc4
Update test snapshot
thornbill Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions components/AppInfoFooter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import { useNavigation } from '@react-navigation/native';
import Constants from 'expo-constants';
import React, { useContext } from 'react';
import { useTranslation } from 'react-i18next';
import { StyleSheet, View } from 'react-native';
import { Text, ThemeContext } from 'react-native-elements';

Expand All @@ -16,7 +15,6 @@ import { getAppName } from '../utils/Device';

const AppInfoFooter = () => {
const navigation = useNavigation();
const { t } = useTranslation();
const { theme } = useContext(ThemeContext);

const textStyle = {
Expand All @@ -38,9 +36,6 @@ const AppInfoFooter = () => {
<Text testID='app-version' style={textStyle}>
{`${Constants.nativeAppVersion} (${Constants.nativeBuildVersion})`}
</Text>
<Text testID='expo-version' style={textStyle}>
{t('settings.expoVersion', { version: Constants.expoVersion })}
</Text>
</View>
);
};
Expand Down
2 changes: 0 additions & 2 deletions components/__tests__/AppInfoFooter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ jest.mock('@react-navigation/native', () => {

describe('AppInfoFooter', () => {
it('should render correctly', () => {
Constants.expoVersion = '39.0.0';
Constants.nativeAppVersion = '1.0.0';
Constants.nativeBuildVersion = '1.0.0.0';
Device.osName = 'Test OS'; // eslint-disable-line no-import-assign, import/namespace
Expand All @@ -45,6 +44,5 @@ describe('AppInfoFooter', () => {
fireEvent(appName, 'onLongPress');
expect(mockNavigate).toHaveBeenCalledWith(Screens.DevSettingsScreen);
expect(getByTestId('app-version')).toHaveTextContent('1.0.0 (1.0.0.0)');
expect(getByTestId('expo-version')).toHaveTextContent('Expo Version: 39.0.0');
});
});
3 changes: 1 addition & 2 deletions langs/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@
"lightTheme": "Use Light Theme",
"systemTheme": "Use System Theme",
"rotationLock": "Rotation Lock",
"tabLabels": "Show Tab Labels",
"expoVersion": "Expo Version: {{version}}"
"tabLabels": "Show Tab Labels"
},
"links": {
"website": "Jellyfin Website",
Expand Down
11 changes: 0 additions & 11 deletions screens/__tests__/__snapshots__/SettingsScreen.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,17 +720,6 @@ exports[`SettingsScreen should render correctly 1`] = `
>
mock (mock)
</Text>
<Text
style={
Object {
"color": "#43484d",
"fontSize": 15,
}
}
testID="expo-version"
>
Expo Version: mock
</Text>
</View>
</View>
</View>
Expand Down
Loading