Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused authAjaxUser function #693

Closed
wants to merge 1 commit into from
Closed

Remove unused authAjaxUser function #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions src/components/__tests__/jellyfinApi.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,33 +142,6 @@ describe('creating image urls', () => {
});
});

describe('test authenticated user ajax', () => {
test('should return rejected promise when server info is undefined', async () => {
// Linting requires this weird spacing.
JellyfinApi.setServerInfo(undefined, '', '');

const resultUserIdIsNull = JellyfinApi.authAjaxUser('', {});

JellyfinApi.setServerInfo('', undefined, '');

const resultAccessTokenIsNull = JellyfinApi.authAjaxUser('', {});

JellyfinApi.setServerInfo('', '');

const resultServerAddressIsNull = JellyfinApi.authAjaxUser('', {});

await expect(resultUserIdIsNull).rejects.toEqual(
'no server info present'
);
await expect(resultAccessTokenIsNull).rejects.toEqual(
'no server info present'
);
await expect(resultServerAddressIsNull).rejects.toEqual(
'no server info present'
);
});
});

describe('getting security headers', () => {
beforeAll(() => {
setupMockCastSenders();
Expand Down
24 changes: 0 additions & 24 deletions src/components/jellyfinApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Api, Jellyfin } from '@jellyfin/sdk';
import axios from 'axios';
import { version as packageVersion } from '../../package.json';
import { ajax } from './fetchhelper';

axios.interceptors.request.use((request) => {
console.log(`requesting url: ${request.url}`);
Expand Down Expand Up @@ -191,27 +190,4 @@ export abstract class JellyfinApi {
`Items/${itemId}/Images/${imgType}/${imgIdx.toString()}?tag=${imgTag}`
);
}

// Authenticated ajax
// eslint-disable-next-line @typescript-eslint/no-explicit-any
public static authAjaxUser(path: string, args: any): Promise<any> {
if (
this.userId === undefined ||
this.accessToken === undefined ||
this.serverAddress === undefined
) {
console.error(
'JellyfinApi.authAjaxUser: No userid/accesstoken/serverAddress present. Skipping request'
);

return Promise.reject('no server info present');
}

const params = {
headers: this.getSecurityHeaders(),
url: this.createUserUrl(path)
};

return ajax({ ...params, ...args });
}
}
Loading