Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate stopping active encodings to jellyfin-sdk-typescript #681

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Nov 7, 2024

This function is currently unused so there were no call sites to fix.

Removing this unused function is an option but there's an open TODO item here:

// TODO Could be useful for garbage collection.
// It needs to predict if the server side transcode needs
// to restart.
// Possibility: Always assume it will. Downside: VTT subs switching doesn't
// need to restart the transcode.
//const requiresStoppingTranscoding = false;
//
//if (requiresStoppingTranscoding) {
// window.playerManager.pause();
// await stopActiveEncodings($scope.playSessionId);
//}

So I thought it was best to leave it in case that's ever addressed.

@nielsvanvelzen nielsvanvelzen merged commit a5db014 into jellyfin:master Nov 7, 2024
5 checks passed
@3flex 3flex deleted the patch-4 branch November 7, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants