Report playback stopped when media finishes #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This consolidates the logic for reporting stopped playback to the server. The MEDIA_FINISHED event is fired when: * End of stream is reached * Error encountered * Playback has been stopped * Playback was interrupted because a new item was loaded https://developers.google.com/cast/docs/reference/web_receiver/cast.framework.events#.EndedReason The current position reported to the server will be the current time reported by the Cast player which will be the most accurate representation. If this is not available, it will fall back to the existing logic of checking the current playback position from the receiver's playback state.
nielsvanvelzen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the logic for reporting stopped playback to the server so it is only reported when MEDIA_FINISHED event is fired. In addition, the current position reported to the server will be the current time reported by the Cast player which will be the most accurate representation. If this is not available, it will fall back to the existing logic of checking the current playback position from the receiver's playback state.
This PR also fixes an issue that occurs when changing audio or subtitle streams. The Cast view would show the "waiting" view after a request to change subtitle or audio streams. Now, the player remains visible when changing streams.