Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't limit max width for h264 streams to the window width #663

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Nov 2, 2024

Cast devices variously support video max widths of 1280, 1920 and 3840. window.innerWidth returns the max width of the receiver page which is not the same resolution and limits h264 streams to a max of 720p on most devices.

Cast devices variously support video max widths of 1280, 1920 and 3840.
window.innerWidth returns the max width of the receiver page which is not
the same resolution and limits h264 streams to a max of 720p on most
devices.
@3flex
Copy link
Contributor Author

3flex commented Nov 2, 2024

@hawken93 the commit introducing this limitation was authored by you on 1/1/21, obviously some time has passed since then so the original issues may have been resolved in CAF or in the Shaka player which this receiver is now configured to use for HLS streams.

I've done limited local testing but this seems to work fine on my Chromecast 2nd gen.

I found various comments saying HLS streaming was problematic when there was a fair bit of dev done a few years back, but I couldn't find specifics, so I'm not sure if whatever problems were seen back then are still an issue today. I'd appreciate any insights here, thank you!

@nielsvanvelzen nielsvanvelzen merged commit 6ac3432 into jellyfin:master Nov 2, 2024
5 checks passed
@3flex 3flex deleted the dont-limit-maxwidth branch November 2, 2024 11:23
@3flex 3flex mentioned this pull request Nov 2, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants