Request mp4 container when transcoding HLS video #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaka player 4.8 and up always remuxes TS to MP4, while the Jellyfin Cast client always requests a TS container. This means any transcoded MP4 stream will be remuxed to TS on the server then remuxed again on the device. As Cast clients (particularly older ones) are low-powered devices, it's important to reduce load on the device when possible. It also avoids unnecessary remuxing on the server in some scenarios. In local testing the Shaka player version is 4.3.4 but this will be updated automatically to 4.9.2 in future. This change is still useful for earlier Shaka player versions since TS remuxing was identified as a problem area anyway, so using MP4 should improve streaming reliablity to Cast devices regardless of the Shaka version.
nielsvanvelzen
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaka player 4.8 and up always remuxes TS to MP4, while the Jellyfin Cast client always requests a TS container. This means any transcoded MP4 stream will be remuxed to TS on the server then remuxed again on the device.
As Cast clients (particularly older ones) are low-powered devices, it's important to reduce load on the device when possible. It also avoids unnecessary remuxing on the server in some scenarios.
In local testing the Shaka player version is 4.3.4 but this will be updated automatically to 4.9.2 in future. This change is still useful for earlier Shaka player versions since TS remuxing was identified as a problem area anyway, so using MP4 should improve streaming reliablity to Cast devices regardless of the Shaka version.