Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use deviceIds enum type where possible #645

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Use deviceIds enum type where possible #645

merged 2 commits into from
Oct 25, 2024

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Oct 25, 2024

No description provided.

nielsvanvelzen
nielsvanvelzen reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the enum to DeviceIds (PascalCase) so it won't be confused with regular variables.

@nielsvanvelzen nielsvanvelzen merged commit 7012aac into jellyfin:master Oct 25, 2024
5 checks passed
@3flex 3flex deleted the any-deviceids branch October 25, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3flex @nielsvanvelzen