Use TvShowsApiGetEpisodesRequest type for getEpisodes query parameters #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a single caller of this function and it passes an object.
This is already set in the query object at the call site.
This is not a valid query parameter for this endpoint.
This is not a valid query parameter for this endpoint.
nielsvanvelzen
approved these changes
Oct 25, 2024
|
Just wondering @nielsvanvelzen would it be a good idea to take advantage of the Jellyfin TypeScript SDK and use the Axios client? It seems some of the implementation in this project could be simplified. I had a look around when taking a look for this change. |
|
Yup definitely, migrating fully to the SDK would make everything more type-safe too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.