Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable typescript-eslint strict checks #639

Merged
merged 2 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default [
eslint.configs.recommended,
jsdoc.configs['flat/recommended'],
eslintPluginPrettierRecommended,
...tseslint.configs.recommended,
...tseslint.configs.strict,
promise.configs['flat/recommended'],
importPlugin.flatConfigs.errors,
importPlugin.flatConfigs.warnings,
Expand Down
1 change: 1 addition & 0 deletions src/components/commandHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { reportPlaybackProgress } from './jellyfinActions';
import { PlaybackManager } from './playbackManager';
import { DocumentManager } from './documentManager';

// eslint-disable-next-line @typescript-eslint/no-extraneous-class
export abstract class CommandHandler {
private static playerManager: framework.PlayerManager;
private static supportedCommands: SupportedCommands = {
Expand Down
1 change: 1 addition & 0 deletions src/components/credentialManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export class credentialManager {
*/
remove(serverId: string): boolean {
if (serverId in this.credentialStore) {
// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
delete this.credentialStore[serverId];

return true;
Expand Down
1 change: 1 addition & 0 deletions src/components/documentManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { parseISO8601Date, TicksPerSecond, ticksToSeconds } from '../helpers';
import { JellyfinApi } from './jellyfinApi';
import { deviceIds, getActiveDeviceId } from './castDevices';

// eslint-disable-next-line @typescript-eslint/no-extraneous-class
export abstract class DocumentManager {
// Duration between each backdrop switch in ms
private static backdropPeriodMs: number | null = 30000;
Expand Down
1 change: 1 addition & 0 deletions src/components/jellyfinApi.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { version as packageVersion } from '../../package.json';
import { ajax } from './fetchhelper';

// eslint-disable-next-line @typescript-eslint/no-extraneous-class
export abstract class JellyfinApi {
// userId that we are connecting as currently
public static userId: string | undefined;
Expand Down
1 change: 1 addition & 0 deletions src/components/playbackManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export interface PlaybackState {
runtimeTicks: number;
}

// eslint-disable-next-line @typescript-eslint/no-extraneous-class
export abstract class PlaybackManager {
private static playerManager: framework.PlayerManager;
private static activePlaylist: Array<BaseItemDto>;
Expand Down
Loading