Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus issues on older Android versions #4376

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

nielsvanvelzen
Copy link
Member

Mixing compose with legacy views keeps challenging us :-)

Changes

  • Fix focusing the "home" button in the toolbar in the item details screen
    • Caused by the "now playing" music composable
  • Fix focusing the "get help" button in the toolbar in the server selection screen
    • Caused by the "notifications" composable

Issues

Fixes #4363

@nielsvanvelzen nielsvanvelzen added bug Something isn't working backportable Change may be backported to a point release (remove label once cherrypicked) labels Jan 3, 2025
@nielsvanvelzen nielsvanvelzen added this to the v0.19.0 milestone Jan 3, 2025
@@ -50,7 +51,9 @@
import org.koin.compose.koinInject

@Composable
fun NowPlayingComposable() {
fun NowPlayingComposable(

Check warning

Code scanning / detekt

One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning

The function NowPlayingComposable is too long (88). The maximum length is 60.
@nielsvanvelzen nielsvanvelzen merged commit b6b2c03 into jellyfin:master Jan 3, 2025
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the focus-fixes branch January 3, 2025 21:05
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.19.0, v0.18.4 Jan 6, 2025
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't navigate to Home button on Amazon Fire TV
2 participants