Offline Mode :: Download media to view without an internet connection at a later time.

[JacobKingDev]

This PR is very much a work in progress. It is far from complete at present and I'm still actively working on it. Expect to find unrefined code, commented code, unlocalised strings etc... Please refrain from reviewing the PR for the time being, until it's out of 'WIP' mode. I'm opening it now so that there is visibility among contributors that this feature is being actively worked on.

PR to finish the implementaiton of 'downloaded/offline media' started by @LePips some time ago. I'll update this PR description with details of the implementation when it's ready for feedback.

[LePips]

oops, I don't remember marking as ready to review, probably meant to do the inverse 🤷

[LePips]

I apologize, I've done a lot of work in #1045 that would require this is be rebased and would probably have conflicts.

Additionally, I've changed the flow a bit and will be implementing some other features where the device owner can decide whether downloads are allowed on their device. We now also pull and store the user data and we would need to check that for download permissions from the server.

This might not be done by the time I take a look at the video player again and implement mpv. While I'm doing that I will be looking at quality-selection and would like this to have it.

I've thought a lot more about how downloaded media would work and can probably provide more guidance later after I think about it.

[franciscomfcmaia]

Hi @LePips! I see that there is a lot of code related to downloads. Is any of this "testable" by us? What should we do to activate the downloads in the source code?

[LePips]

Sorry, but the existing downloads work was essentially a POC for a trip that I took a long time ago. It is not meant by any means to be used by users, and frankly any developer looking at my work would understand how undeveloped the entire feature is.

[BenStokmans]

@JacobKingDev I've opened a new PR concerning the offline media functionality, as your repo has been stale for a while and needs to be rebased on the newest changes. Do you mind me taking over the PR? If you still intend to work on it, I would love to do it in a cooperative fashion.

[LePips]

Doing some cleanup and closing in preference of #1065.