-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Admin Dashboard - User Profiles #1328
base: main
Are you sure you want to change the base?
Conversation
This is currently 'ready' but the notification to update the image on update isn't firing 100% of the time. So sometimes, when I change a user image it just never changes even though it's been updated on the server. Happens about 50% of the time so I think I have an issue on my end to work out. |
I've played around with this and I don't think that the issue is due to the notification being sent but a caching issue. If I edit the profile image for a different user then nothing will be properly updated for that user, even on the user sign in view. If I exit the admin user and then sign into the user I edited, then all of the images will appear properly. |
Interesting. What is being done on the local user level to clear the cache on pfp update? I tried to mirror/reuse what I could but I could have missed something. Plus, I need to clean up this PR a bit it's a little hectic... |
Daw, I merged it wrong... This branch is broken but I needed to redo this anyway. I'm going to wipe and try again here off of Main later this week. |
28121a0
to
d001a96
Compare
…set image / other stuff like delete & username.
This should be good but I'm back to having the same issue as before where I'm unable to get images to refresh appropriately throughout. Going from no image -> image works appropriately but image -> new image doesn't always refresh. Is that image caching or did I screw up the notifications? There is also a weird one where if you change your username from Last item, I am using the 🎉 This should be the final |
Swiftfin/Views/AdminDashboardView/ServerUserDetailsView/ServerUserDetailsView.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As some clarification, the current UserProfileHeroImage
should be UserProfileImage
. The Hero
attribute should be used for the views that have the profile image as the large image, which then can use UserProfileImage
.
Ah! I probably should have googled that first haha... I've updated this to reflect what the names should be! |
Summary
Allows for editing/deleting a user image. This is just repurposing the existing UserProfileImagePicker to be callable from both current userSession or another user. Also allows for editing a user's account name.
This edits the layout of the ServerUserDetailView to be more in line with the UserProfileView
Screenshots
Updated View
Update Username
Image Options