-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Localizations #1071
Clean up Localizations #1071
Conversation
This should all be done now! I definitely lost some steam on the descriptive comments for the labels but it's a step up over what was there (or not there) previously. The categories started to get a little tough since some labels ended up crossing categories. All in all, I'm up to change anything there that doesn't make sense but for the most part I think this resolves what I set out to do. Other than that, I found that the Grid vs List settings had labels but they weren't using them. This is the only actual code I updated to make sure they stopped showing up as unused labels. @LePips I left in the labels that weren't in use commented out at the bottom. I assume some of them will have some use later so removing them and losing those translations only to add them back later could be a loss? Your call for these. Things like "Season" I am genuinely surprised aren't actually in use. If you want to let me know which ones we might want to hold onto even if they're currently not in use, I can move those back in as labels again. Let me know! |
Going over the settings I realized there might be another item to this PR. Some of our settings are TBH, I don't think there is a wrong way to do this but I thought I'd offer up making these changes while I'm working on these labels just to get the labels cleaned up all at once. |
This is pretty out of date now. I am going to close this out and look at this another day! |
Sorry for not looking at this forever ago but I don't think we should look at this for a while as I want to focus on other development before we possibly bork the localizations. |
No worries at all! Yeah, even within some of the stuff I was doing this was getting out of date. Done the road I might take a crack at this again but I realize this is a project that needs to start and end really quickly or it risks getting out of date. I'll keep you posted before I try again! |
Discussed to resolve: #518
The goal of this PR is to: