Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Localizations #1071

Closed
wants to merge 7 commits into from
Closed

Clean up Localizations #1071

wants to merge 7 commits into from

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented May 26, 2024

Discussed to resolve: #518

The goal of this PR is to:

  • Group labels into categories
  • Add descriptions of labels to the best of my ability (Some may need revisions later based on usage)
  • Remove unused labels
  • Ensure that the project still builds for both tvOS and iOS after labels are removed (see 3)

@JPKribs JPKribs changed the title [WIP] Label Cleanup [WIP] Clean up Localizations May 26, 2024
@JPKribs JPKribs closed this May 26, 2024
@JPKribs JPKribs reopened this May 26, 2024
@JPKribs JPKribs marked this pull request as ready for review July 18, 2024 06:13
@JPKribs
Copy link
Member Author

JPKribs commented Jul 18, 2024

This should all be done now! I definitely lost some steam on the descriptive comments for the labels but it's a step up over what was there (or not there) previously. The categories started to get a little tough since some labels ended up crossing categories. All in all, I'm up to change anything there that doesn't make sense but for the most part I think this resolves what I set out to do.

Other than that, I found that the Grid vs List settings had labels but they weren't using them. This is the only actual code I updated to make sure they stopped showing up as unused labels.

@LePips I left in the labels that weren't in use commented out at the bottom. I assume some of them will have some use later so removing them and losing those translations only to add them back later could be a loss? Your call for these. Things like "Season" I am genuinely surprised aren't actually in use. If you want to let me know which ones we might want to hold onto even if they're currently not in use, I can move those back in as labels again.

Let me know!

@JPKribs JPKribs changed the title [WIP] Clean up Localizations Clean up Localizations Jul 18, 2024
@JPKribs
Copy link
Member Author

JPKribs commented Aug 3, 2024

Going over the settings I realized there might be another item to this PR. Some of our settings are Title Case while others are Sentence case. In mind, it might make sense to use this PR where I am already messing with all of the labels and use this as a chance to standardize this. The question is, When do we want to use each casing type?

TBH, I don't think there is a wrong way to do this but I thought I'd offer up making these changes while I'm working on these labels just to get the labels cleaned up all at once.

Sentence Case Screenshot 2024-08-03 at 17 30 05
Title Case Screenshot 2024-08-03 at 17 30 35

@JPKribs
Copy link
Member Author

JPKribs commented Aug 27, 2024

This is pretty out of date now. I am going to close this out and look at this another day!

@JPKribs JPKribs closed this Aug 27, 2024
@LePips
Copy link
Member

LePips commented Aug 27, 2024

Sorry for not looking at this forever ago but I don't think we should look at this for a while as I want to focus on other development before we possibly bork the localizations.

@JPKribs
Copy link
Member Author

JPKribs commented Aug 31, 2024

No worries at all! Yeah, even within some of the stuff I was doing this was getting out of date. Done the road I might take a crack at this again but I realize this is a project that needs to start and end really quickly or it risks getting out of date.

I'll keep you posted before I try again!

@JPKribs JPKribs deleted the labelCleanup branch October 7, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Localizations
2 participants