Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[very rough draft]: add web visualizer #314

Merged
merged 10 commits into from
Sep 9, 2024

Conversation

kgarner7
Copy link
Collaborator

Adds a audio visualizer for web player. This is a very rough draft; there are probably better visualizers/maybe multiple visualizers, but I personally am fond of this one.

Notes:

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 1:25am

@kgarner7
Copy link
Collaborator Author

I've elected to fall back into custom implementation, for the following reasons:

  • the data returned from getByteFrequencyData represents liner scale. This uses exponential scaling
  • The frequency bins depends on the current frequency. For example, if you set 96 kHz, the returned data is [0, 48 kHz]. This PR only shows between [16, 20k] (so higher sample rates means less bins)
  • Reduce update rate (50-60 ms interval seem fine, others were using requestAnimationFrame, which happens more often). I guess you could use requestAnimationFrame and then using the timestamp

- Note: fixed to 4.1.1 because 4.2.0 uses esm which breaks in the current workflow...
@kgarner7 kgarner7 marked this pull request as ready for review September 9, 2024 01:24
@kgarner7 kgarner7 merged commit 74aa88e into jeffvli:development Sep 9, 2024
2 of 3 checks passed
@kgarner7 kgarner7 deleted the visualizer branch September 9, 2024 01:25
@kgarner7 kgarner7 mentioned this pull request Sep 9, 2024
spiceratops referenced this pull request in spiceratops/k8s-gitops Sep 12, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/jeffvli/feishin](https://redirect.github.com/jeffvli/feishin)
| minor | `0.8.1` -> `0.9.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>jeffvli/feishin (ghcr.io/jeffvli/feishin)</summary>

###
[`v0.9.0`](https://redirect.github.com/jeffvli/feishin/releases/tag/v0.9.0):
0.9.0

[Compare
Source](https://redirect.github.com/jeffvli/feishin/compare/v0.8.1...v0.9.0)

#### Highlights

- (UI) Added visualizer to fullscreen player (web audio only)
([#&#8203;314](https://redirect.github.com/jeffvli/feishin/issues/314))
-   (UI) Added context menu item to play items shuffled
- (UI) Fixed issue where app could crash if duplicates rows existed in
certain tables
([#&#8203;729](https://redirect.github.com/jeffvli/feishin/issues/729))
- (UI, Jellyfin) Fixed issue where image aspect ratio was not displaying
correctly
-   (Desktop) Added setting to disable OS tray

#### What's Changed

- \[very rough draft]: add web visualizer by
[@&#8203;kgarner7](https://redirect.github.com/kgarner7) in
[https://github.com/jeffvli/feishin/pull/314](https://redirect.github.com/jeffvli/feishin/pull/314)

**Full Changelog**:
jeffvli/feishin@v0.8.1...v0.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant