Hardcoded urls replaced #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py find command to remove warnings and errors finding files'
…n template. Modified bigboard_mainloop.js to use the global variables instead of hardcoded relative ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit was to solve errors I was having with spatialite for my development version needing GeoManger objects (https://docs.djangoproject.com/en/dev/ref/contrib/gis/model-api/#geomanager).
The second are just the changes you made the other day.
The third commit is the major change I would like to contribute. Previously you had the api urls hardcoded in the js. I added names to the regular views and in the room.template.html file I created global variables for each view and resource by reversing the url. This will make it more flexible to use the bigboard js code in locations other than the main view and allows the views to be accessed easily from any template or view without hardcoding the url. I modified all the urls in bigboard_mainloop.js to use these global variables and it seems to work just fine.
Now to use bigboard_mainloop.js users will either hsve to hardcode the urls in their script or do as I have done for the room template.