Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re-ran dist-build/apple-xcframework.sh from libsodium with
LIBSODIUM_FULL_BUILD=1
, and manually corrected the fileSodium/libsodium/version.h
to match. For the sake of simplicity about what actually changed, I also re-ordered theAvailableLibraries
array inClibsodium.xcframework/Info.plist
from what was output by this script so as to match the current file ordering (and therefore this file is now unchanged).This was run using Xcode 12.5.1 on revision 7d71804ee05f71b65c94282f706c5aa82b279e8a of libsodium (as currently documented in the readme).
This exposes some currently missing functionality from Clibsodium
swift-sodium/Sodium/libsodium/sodium_lib.h
Lines 56 to 67 in 1d51e8e
Even though this doesn't change the swift library, I think it makes sense for this package to make all of libsodium available in-case any of the low level functionality is needed?
I've opened this PR for convenience, but I won't be offended if you prefer to build the modified binaries yourself :)
Closes #248