Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Members show to include inherited members #508

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

jdalrymple
Copy link
Owner

feat: Adding ability to get a singular member of a project or group, including inheritedMemebrs

BREAKING CHANGE: Updated the Members.all function to have the inheritedMembers option to be in the optional object.

closes: #507

…including inheritedMemebrs

BREAKING CHANGE: Updated the Members.all function to have the inheritedMembers option to be in the optional object.

closes: #507
Copy link
Contributor

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change LGTM even if it is breaking 🗡

@jdalrymple jdalrymple merged commit 807171c into master Dec 9, 2019
@jdalrymple jdalrymple deleted the 507-show-inherited branch December 9, 2019 10:22
jdalrymple pushed a commit that referenced this pull request Dec 9, 2019
# [13.0.0](12.1.0...13.0.0) (2019-12-09)

### Features

* Adding ability to get a singular member of a project or group, including inheritedMemebrs ([#508](#508)) ([807171c](807171c)), closes [#507](#507)

### BREAKING CHANGES

* Updated the Members.all function to have the inheritedMembers option to be in the optional object.
@jdalrymple
Copy link
Owner Author

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

import { AccessLevel } from './ResourceAccessRequests';

interface IncludeInherited {
includeInherited?: boolean;
Copy link
Contributor

@jetersen jetersen Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm

Argument of type '{ includeInherited: boolean; }' is not assignable to parameter of type 'boolean'.ts(2345)

api.ProjectMembers.all(project.id, { includeInherited: false })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for all inherited members endpoint (ancestor groups) - /groups/:id/members/all/:user_id
2 participants