Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for all inherited members endpoint (ancestor groups) - /groups/:id/members/all/:user_id #507

Closed
MadLittleMods opened this issue Dec 9, 2019 · 6 comments · Fixed by #508
Closed

Add support for all inherited members endpoint (ancestor groups) - /groups/:id/members/all/:user_id #507

MadLittleMods opened this issue Dec 9, 2019 · 6 comments · Fixed by #508

Comments

@MadLittleMods
Copy link

Add support for the following endpoints as documented in https://docs.gitlab.com/ee/api/members.html#get-a-member-of-a-group-or-project-including-inherited-members

  • GET /groups/:id/members/all/:user_id
  • GET /projects/:id/members/all/:user_id

This endpoint is special because it "includ[es] members inherited through ancestor groups."

We are using this in Gitter to support GitLab based communities/rooms, https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1679

Normal endpoints which don't include inherited ancestor group members (these are already supported), https://docs.gitlab.com/ee/api/members.html#get-a-member-of-a-group-or-project

GET /groups/:id/members/:user_id
GET /projects/:id/members/:user_id
@jetersen
Copy link
Contributor

jetersen commented Dec 9, 2019

this is already supported.
https://github.com/node-gitlab/node-gitlab/blob/63b11574aa1db3b88be3b3baeb16dbaceb9e566b/src/core/templates/ResourceMembers.ts#L17

set includeInherited to true

@jetersen
Copy link
Contributor

jetersen commented Dec 9, 2019 •
edited
Loading

ah, this was introduced in GitLab 12.4 as note by https://docs.gitlab.com/ee/api/members.html#get-a-member-of-a-group-or-project-including-inherited-members

So obviously this is currently not supported 😓

jdalrymple added a commit that referenced this issue Dec 9, 2019
@jdalrymple
feat: Adding ability to get a singular member of a project or group, …
0bdd475 
…including inheritedMemebrs

BREAKING CHANGE: Updated the Members.all function to have the inheritedMembers option to be in the optional object.

closes: #507
@jdalrymple jdalrymple mentioned this issue Dec 9, 2019
Merged
jdalrymple added a commit that referenced this issue Dec 9, 2019
@jdalrymple
feat: Adding ability to get a singular member of a project or group, …
807171c 
…including inheritedMemebrs (#508)

BREAKING CHANGE: Updated the Members.all function to have the inheritedMembers option to be in the optional object.

closes: #507
jdalrymple pushed a commit that referenced this issue Dec 9, 2019
@semantic-release-bot
chore(release): 13.0.0 [skip ci]
99e07ec 
# [13.0.0](12.1.0...13.0.0) (2019-12-09)

### Features

* Adding ability to get a singular member of a project or group, including inheritedMemebrs ([#508](#508)) ([807171c](807171c)), closes [#507](#507)

### BREAKING CHANGES

* Updated the Members.all function to have the inheritedMembers option to be in the optional object.
@jdalrymple
Copy link
Owner

🎉 This issue has been resolved in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jetersen
Copy link
Contributor

jetersen commented Dec 9, 2019

btw I love the fact that Gitlab/gitter is using this library 🥰

@MadLittleMods
Copy link
Author

@jdalrymple @Casz I got this working and all integrated now 🚀 Thanks for the great support and quick update ❤️

@jdalrymple
Copy link
Owner

@Casz Next step is to clean it up a bit #483 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resource Members show to include inherited members jdalrymple/gitbeaker
3 participants
@MadLittleMods @jetersen @jdalrymple