Extend support for the reformat function & add tests for verification (…

…#3576)
jdalrymple · Apr 25, 2024 · bc3f390 · bc3f390
1 parent b30c703
commit bc3f390
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/packages/core/src/infrastructure/Utils.ts b/packages/core/src/infrastructure/Utils.ts
@@ -74,13 +74,13 @@ export function reformatObjectOptions(
   obj: Record<string, unknown>,
   prefixKey: string,
   decamelizeValues = false,
-) {
+): Record<string, string> {
   const formatted = decamelizeValues ? decamelizeKeys(obj) : obj;
 
   return QS.stringify({ [prefixKey]: formatted }, { encode: false })
     .split('&')
     .reduce((acc: Record<string, string>, cur: string) => {
-      const [key, val] = cur.split('=');
+      const [key, val] = cur.split(/=(.*)/);
 
       acc[key] = val;
 

diff --git a/packages/core/test/unit/infrastructure/Utils.ts b/packages/core/test/unit/infrastructure/Utils.ts
@@ -1,4 +1,4 @@
-import { appendFormFromObject, endpoint } from '../../../src/infrastructure';
+import { appendFormFromObject, endpoint, reformatObjectOptions } from '../../../src/infrastructure';
 
 describe('appendFormFromObject', () => {
   it('should convert object key/values to formdata instance', () => {
@@ -35,3 +35,29 @@ describe('endpoint', () => {
     expect(url).toBe('/projects/1');
   });
 });
+
+describe('reformatObjectOptions', () => {
+  it('should convert simple nested object to be query parameter friendly', () => {
+    const data = {
+      a: {
+        b: 'test',
+      },
+    };
+
+    const formatted = reformatObjectOptions(data, 'test');
+
+    expect(formatted).toMatchObject({ 'test[a][b]': 'test' });
+  });
+
+  it('should convert nested object with "=" characters in the value', () => {
+    const data = {
+      a: {
+        b: '=5',
+      },
+    };
+
+    const formatted = reformatObjectOptions(data, 'test');
+
+    expect(formatted).toMatchObject({ 'test[a][b]': '=5' });
+  });
+});