Merge to master #218
Merged
Merge to master #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change panics to return Results instead.
Makes spline and clip independent of Vary. Lerp has a blanket impl for all Affine<f32> types.
Easy now that Lerp is separate. Factor coefficient computation to a separate function. The coefficients are constant for a given spline, so can be precomputed if the spline is evaluated multiple times (eg. by an iterator).
* Store points in Mesh * Use points in solids * Parse points in obj loader * Change projection matrix apply to take Point
* Make Lerp supertrait of Vary * impl Lerp for () and (,) * Also add doc comments and doctest
* Invert outcode bits so 1 means outside * Use plain u8 for outcode again * Use separate ClipPlane type rather than alias * Add and improve comments
Also make the samples iterator opaque now that we have RPIT in traits.
Re-export "stuttery" names like stats::Stats. Clean up imports.
Also refactor obj loading a bit.
Use the re-exports consistently everywhere.
Also rename Lathe::pts to points
Allow subdivision into several stacked vertical segments. Useful for approximating more complex shapes with nonlinear transforms.
Use the constructor in bezier demo to render a multi-segment spline.
Demos were not being built due to missing features.
The basis vectors are supposed to be the column, not row, vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.