Skip to content

Commit

Permalink
Issue 42 (#43)
Browse files Browse the repository at this point in the history 
* Added assembly plugin. fixes #42.

* Corrected. Just a sink.
  • Loading branch information
@jcustenborder
jcustenborder authored Apr 3, 2018
1 parent 7b36790 commit 68b2e59
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 1 deletion.
40 changes: 40 additions & 0 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,44 @@
<version>3.10</version>
</dependency>
</dependencies>
<build>
<plugins>
<plugin>
<groupId>io.confluent</groupId>
<artifactId>kafka-connect-maven-plugin</artifactId>
<version>0.9.0</version>
<executions>
<execution>
<goals>
<goal>kafka-connect</goal>
</goals>
<configuration>
<ownerUsername>jcustenborder</ownerUsername>
<confluentControlCenterIntegration>true
</confluentControlCenterIntegration>
<documentationUrl>
https://jcustenborder.github.io/kafka-connect-documentation/
</documentationUrl>
<ownerName>Jeremy Custenborder</ownerName>
<dockerNamespace>jcustenborder</dockerNamespace>
<dockerName>kafka-connect-docker</dockerName>
<pluginTypes>
<pluginType>source</pluginType>
</pluginTypes>
<tags>
<tag>File</tag>
<tag>Flume</tag>
<tag>csv</tag>
<tag>json</tag>
</tags>
<title>Kafka Connect Spooldir</title>
<supportUrl>${pom.issueManagement.url}</supportUrl>
<supportSummary>Support provided through community involvement.
</supportSummary>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
2 changes: 1 addition & 1 deletion src/main/java/com/github/jcustenborder/kafka/connect/spooldir/SpoolDirJsonSourceTask.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected void configure(InputStream inputStream, Map<String, String> metadata,
this.offset = -1;

if (null != lastOffset) {
int skippedRecords = 0;
int skippedRecords = 1;

This comment has been minimized.

Sign in to view

Copy link
@tboonIV

tboonIV Mar 11, 2021

hi, sorry for disturbing but I got a question here -- Should skippedRecords start from 0?
As I assume 'lastOffset' is the offset of the last record had read in a file. I tested this and found the last record always get write again into the topic when I drop the same file.
while (this.iterator.hasNext() && skippedRecords <= lastOffset) {
next();
skippedRecords++;
Expand Down

0 comments on commit 68b2e59

Please sign in to comment.