Feature/record expiry #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arnkthr Can you help me understand why this change is needed? |
Hi @jcustenborder, sorry, the change aims to provide the functionality mentioned in this issue #26 |
|
Are we waiting on anything before we can approve and merge this other than resolving the merge conflict? |
|
Is there a reason that this isn't being merged? Setting TTL on cache entries so they expire eventually seems like a complete no-brainer feature to add, but this has been sitting here for over 18 months. |
|
There is a 2.0 version of the connector which has this functionality. It's been in the works for a while. This also required some refactoring to support sentinel and cluster. |
|
A V2 of this is great news! Two questions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration to allow the connector to send records which will expire from redis at a globally configured time.