fix odd? and even? for non integers #242

CHANGELOG.md

@@ -10,6 +10,8 @@
 * fix macro expand on let with more than one binding
 * fix shallow `list->array`
 * fix resolving promises inside quoted promise realm
+* fix undocumented symbol syntax extensions
+* fix odd? even? on non integers
 
 ## 1.0.0-beta.17
 ### Breaking

src/lips.js

@@ -5362,10 +5362,14 @@ LNumber.prototype.isOdd = function() {
         if (this.isBigNumber()) {
             return this.__value__ % BigInt(2) === BigInt(1);
         }
+        if (this.__type__ === 'float') {
+            throw new Error('Invalid number float');
+        }
         return this.__value__ % 2 === 1;
     } else if (LNumber.isBN(this.__value__)) {
         return this.__value__.isOdd();
     }
+    throw new Error(`Invalid number ${this.__type__}`);
 };
 // -------------------------------------------------------------------------
 LNumber.prototype.isEven = function() {

tests/numbers.scm

@@ -1006,3 +1006,19 @@
                     (0.5i +0.46211715726000974i)
                     (1/2+1/2i 0.40389645531602575+0.5640831412674985i)
                     (+1/2i +0.46211715726000974i)))))
+
+(test "numbers: should calculate odd? / even?"
+      (lambda (t)
+        (t.is (odd? 1) #t)
+        (t.is (odd? 2) #f)
+        (t.is (even? 10) #t)
+        (t.is (even? 21) #f)))
+
+(test "numbers: should throw exception odd? / event?"
+      (lambda (t)
+        (for-each (lambda (op?)
+                    (t.is (to.throw (op? 10+10i)) #t)
+                    (t.is (to.throw (op? 1/2)) #t)
+                    (t.is (to.throw (op? 1.2)) #t)
+                    (t.is (to.throw (op? 1.2)) #t))
+                  '(even? odd?))))