Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide cursor on touch events. #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

AtomToast
Copy link

based on #25 but with fixed indentation

works perfectly on my gpd win max

@haraldkubota
Copy link

This might be a silly question (I got no touch pad to test this), but isn't the touch pad basically a mouse-replacement, so when it get activated, then the mouse pointer should NOT be hidden?
I see the point for a virtual keyboard though: if that is opened and you touch the virtual keys, then the pointer should disappear.
Is that what this change does?

@AtomToast
Copy link
Author

It is a mouse replacement. However I'd consider the cursor part of the mouse user scheme. It really doesn't add anything to a touch experience since you are not trying to move a cursor around with your finger but to just hit a thing on your screen and for that action to get executed.
The cursor staying around is just visual noise and kind of distracting.

I don't see how having a virtual keyboard would be different from hitting any other button on your screen.
If you look at other touch devices like phones you will never find a cursor staying around where you tapped the screen. This is also the same behaviour on for example windows devices with a touchscreen. The mouse cursor becomes invisible when you use your touchscreen.

If you are still wondering I can also record a video later for you to see the difference

@jcs
Copy link
Owner

jcs commented Sep 23, 2020

I think this needs to be put behind an option to enable it.

@haraldkubota
Copy link

AtomToast, thanks for the explanation. I was not thinking about touch screens at all. Makes perfect sense there to hide the pointer.

@AtomToast
Copy link
Author

I now added the option to keep the cursor after there was a touch event. I still think the correct default behaviour should be to hide it when using a touch screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants