Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playlists #321

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Fix playlists #321

merged 7 commits into from
Sep 20, 2023

Conversation

jcraigk
Copy link
Owner

@jcraigk jcraigk commented Sep 20, 2023

Fixes #320

@jcraigk jcraigk merged commit a178baf into main Sep 20, 2023
@jcraigk jcraigk deleted the fix-playlists branch September 20, 2023 00:21
@PlaylistBoy
Copy link

Hello!
Thanks for the fix. Unfortunately, it's not quite all the way fixed yet. Multiple shows can now be added to the "active playlist" (yay!) but the "update existing playlist" feature on the dropdown still remains unclickable (screenshot attached). It offers the option to "update existing playlist" but hovering over it/clicking it does nothing. This is on Windows 10/PC/Chrome.
Anyway, in the meantime, just having the multiple shows in the active playlist helps. It's a start! And thanks for your patience with me!
update existing playlist

@jcraigk
Copy link
Owner Author

jcraigk commented Sep 20, 2023

From your screenshot it looks like you are clicking Save on an "Untitled Playlist", which means it hasn't been saved yet, so that is why the "Update existing playlist" is greyed out. Please let me know if you have suggestions for UI improvement to make it more clear why that's greyed out.

I just double checked these features on phish.in and they seem to work. See attached screenshots. First one is from an existing saved playlist. Click Save and the default is "Update existing playlist". Empty out the playlist and click Save, and the default is "Create new playlist".

Screenshot 2023-09-20 at 10 15 01 AM Screenshot 2023-09-20 at 10 15 13 AM

@jcraigk
Copy link
Owner Author

jcraigk commented Sep 21, 2023

I updated the language slightly to hopefully make things a bit clearer.

Screenshot 2023-09-20 at 10 38 06 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlist feature not fully functional?
2 participants