Remove frozen string literal comments

jcraigk · Oct 3, 2023 · 2e86995 · 2e86995
1 parent 6ee8c48
commit 2e86995
Show file tree

Hide file tree

Showing 193 changed files with 13 additions and 205 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -75,6 +75,8 @@ Style/Documentation:
   Enabled: false
 Style/FormatStringToken:
   Enabled: false
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: never
 Style/HashTransformValues:
   Enabled: false
 Style/MissingRespondToMissing:

diff --git a/Gemfile b/Gemfile
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 source 'https://rubygems.org'
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 

diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,2 @@
-# frozen_string_literal: true
 require_relative 'config/application'
 Rails.application.load_tasks
diff --git a/app/controllers/ambiguity_controller.rb b/app/controllers/ambiguity_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class AmbiguityController < ApplicationController
   include Ambiguity::Date
   include Ambiguity::DayOfYear

diff --git a/app/controllers/api/v1/api_controller.rb b/app/controllers/api/v1/api_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::ApiController < ActionController::Base # rubocop:disable Rails/ApplicationController
   include ApiAuth
 

diff --git a/app/controllers/api/v1/eras_controller.rb b/app/controllers/api/v1/eras_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::ErasController < Api::V1::ApiController
   caches_action_params :index
   caches_action_params :show, %i[id]

diff --git a/app/controllers/api/v1/playlists_controller.rb b/app/controllers/api/v1/playlists_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::PlaylistsController < Api::V1::ApiController
   caches_action_params :show, %i[id]
 

diff --git a/app/controllers/api/v1/search_controller.rb b/app/controllers/api/v1/search_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::SearchController < Api::V1::ApiController
   def index
     return respond_with_invalid_term unless results

diff --git a/app/controllers/api/v1/shows_controller.rb b/app/controllers/api/v1/shows_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::ShowsController < Api::V1::ApiController
   caches_action_params :index
   caches_action_params :show

diff --git a/app/controllers/api/v1/songs_controller.rb b/app/controllers/api/v1/songs_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::SongsController < Api::V1::ApiController
   caches_action_params :index
   caches_action_params :show

diff --git a/app/controllers/api/v1/tags_controller.rb b/app/controllers/api/v1/tags_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::TagsController < Api::V1::ApiController
   caches_action_params :index
   caches_action_params :show

diff --git a/app/controllers/api/v1/tours_controller.rb b/app/controllers/api/v1/tours_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::ToursController < Api::V1::ApiController
   caches_action_params :index
   caches_action_params :show

diff --git a/app/controllers/api/v1/tracks_controller.rb b/app/controllers/api/v1/tracks_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::TracksController < Api::V1::ApiController
   caches_action_params :index
   caches_action_params :show

diff --git a/app/controllers/api/v1/venues_controller.rb b/app/controllers/api/v1/venues_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::VenuesController < Api::V1::ApiController
   caches_action_params :index
   caches_action_params :show

diff --git a/app/controllers/api/v1/years_controller.rb b/app/controllers/api/v1/years_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Api::V1::YearsController < Api::V1::ApiController
   caches_action_params :index, %i[include_show_counts]
   caches_action_params :show

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ApplicationController < ActionController::Base
   include ApplicationHelper
   protect_from_forgery

diff --git a/app/controllers/concerns/ambiguity/date.rb b/app/controllers/concerns/ambiguity/date.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Ambiguity::Date
   def slug_as_date
     return false if date_from_slug.blank?

diff --git a/app/controllers/concerns/ambiguity/day_of_year.rb b/app/controllers/concerns/ambiguity/day_of_year.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Ambiguity::DayOfYear
   TODAY_SLUGS = %w[today today-in-history].freeze
 

diff --git a/app/controllers/concerns/ambiguity/song_title.rb b/app/controllers/concerns/ambiguity/song_title.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Ambiguity::SongTitle
   def slug_as_song
     return false if song.blank?

diff --git a/app/controllers/concerns/ambiguity/tour_name.rb b/app/controllers/concerns/ambiguity/tour_name.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Ambiguity::TourName
   def slug_as_tour
     return false if tour.blank?

diff --git a/app/controllers/concerns/ambiguity/venue_name.rb b/app/controllers/concerns/ambiguity/venue_name.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Ambiguity::VenueName
   def slug_as_venue
     return false if venue.blank?

diff --git a/app/controllers/concerns/ambiguity/year.rb b/app/controllers/concerns/ambiguity/year.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Ambiguity::Year
   def slug_as_year
     return false if year_from_slug.blank?

diff --git a/app/controllers/concerns/ambiguity/year_range.rb b/app/controllers/concerns/ambiguity/year_range.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Ambiguity::YearRange
   def slug_as_year_range
     return false if year_range_from_slug.blank?

diff --git a/app/controllers/concerns/api_auth.rb b/app/controllers/concerns/api_auth.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module ApiAuth
   def require_auth
     return true if phish_od? # Skip auth for legacy iOS PhishOD app

diff --git a/app/controllers/downloads_controller.rb b/app/controllers/downloads_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class DownloadsController < ApplicationController
   def track_info # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     return render json: { success: false } unless track

diff --git a/app/controllers/eras_controller.rb b/app/controllers/eras_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ErasController < ApplicationController
   caches_action_params :index
 

diff --git a/app/controllers/feeds_controller.rb b/app/controllers/feeds_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class FeedsController < ApplicationController
   def rss
     @announcements = Announcement.order(created_at: :desc)

diff --git a/app/controllers/likes_controller.rb b/app/controllers/likes_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class LikesController < ApplicationController
   before_action :authorize_user!
 

diff --git a/app/controllers/map_controller.rb b/app/controllers/map_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class MapController < ApplicationController
   def index
     params[:date_start] ||= '1983-01-01'

diff --git a/app/controllers/my_controller.rb b/app/controllers/my_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class MyController < ApplicationController
   def my_shows
     return unless current_user

diff --git a/app/controllers/playlists_controller.rb b/app/controllers/playlists_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class PlaylistsController < ApplicationController
   EMPTY_PLAYLIST = {
     tracks: [],

diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ReportsController < ApplicationController
   caches_action_params :missing_content
 

diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class SearchController < ApplicationController
   def results
     perform_search

diff --git a/app/controllers/songs_controller.rb b/app/controllers/songs_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class SongsController < ApplicationController
   caches_action_params :index, %i[char sort]
 

diff --git a/app/controllers/static_pages_controller.rb b/app/controllers/static_pages_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class StaticPagesController < ApplicationController
   def faq
     render_xhr_without_layout

diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class TagsController < ApplicationController
   caches_action_params :index
   caches_action_params :show, %i[entity]

diff --git a/app/controllers/top_shows_controller.rb b/app/controllers/top_shows_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class TopShowsController < ApplicationController
   caches_action_params :index
 

diff --git a/app/controllers/top_tracks_controller.rb b/app/controllers/top_tracks_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class TopTracksController < ApplicationController
   caches_action_params :index
 

diff --git a/app/controllers/venues_controller.rb b/app/controllers/venues_controller.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class VenuesController < ApplicationController
   caches_action_params :index
 

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module ApplicationHelper
   def clear_both
     tag.div(style: 'clear: both;')

diff --git a/app/helpers/navigation_helper.rb b/app/helpers/navigation_helper.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module NavigationHelper
   def global_nav(controller) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     str = ''

diff --git a/app/helpers/playlist_helper.rb b/app/helpers/playlist_helper.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module PlaylistHelper
   def playlist_filter_hash
     {

diff --git a/app/helpers/sort_helper.rb b/app/helpers/sort_helper.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module SortHelper
   def sort_songs_and_venues_links(item_hash)
     item_hash.map do |k, v|

diff --git a/app/helpers/tag_helper.rb b/app/helpers/tag_helper.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module TagHelper
   def display_tag_instances(tag_instances, css_class = 'show_tag_container')
     tag_groups =

diff --git a/app/helpers/track_helper.rb b/app/helpers/track_helper.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module TrackHelper
   def next_gap_link(song, date) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     next_show =

diff --git a/app/models/announcement.rb b/app/models/announcement.rb
@@ -1,3 +1,2 @@
-# frozen_string_literal: true
 class Announcement < ApplicationRecord
 end
diff --git a/app/models/api_key.rb b/app/models/api_key.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ApiKey < ApplicationRecord
   scope :revoked, -> { where.not(revoked_at: nil) }
   scope :not_revoked, -> { where(revoked_at: nil) }

diff --git a/app/models/application_record.rb b/app/models/application_record.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 end
diff --git a/app/models/known_date.rb b/app/models/known_date.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class KnownDate < ApplicationRecord
   validates :date, uniqueness: true
   validates :phishnet_url, :venue, :location, presence: true

diff --git a/app/models/like.rb b/app/models/like.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Like < ApplicationRecord
   belongs_to :likable, polymorphic: true, counter_cache: true
   belongs_to :user

diff --git a/app/models/playlist.rb b/app/models/playlist.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Playlist < ApplicationRecord
   MAX_TRACKS = 100
 

diff --git a/app/models/playlist_bookmark.rb b/app/models/playlist_bookmark.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class PlaylistBookmark < ApplicationRecord
   belongs_to :playlist
   belongs_to :user

diff --git a/app/models/playlist_track.rb b/app/models/playlist_track.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class PlaylistTrack < ApplicationRecord
   belongs_to :playlist
   belongs_to :track

diff --git a/app/models/show.rb b/app/models/show.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Show < ApplicationRecord
   belongs_to :tour, counter_cache: true
   belongs_to :venue, counter_cache: true

diff --git a/app/models/show_tag.rb b/app/models/show_tag.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ShowTag < ApplicationRecord
   belongs_to :show, counter_cache: :tags_count
   belongs_to :tag, counter_cache: :shows_count

diff --git a/app/models/song.rb b/app/models/song.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Song < ApplicationRecord
   has_many :songs_tracks, dependent: :destroy
   has_many :tracks, through: :songs_tracks

diff --git a/app/models/songs_track.rb b/app/models/songs_track.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class SongsTrack < ApplicationRecord
   belongs_to :track
   belongs_to :song, counter_cache: :tracks_count

diff --git a/app/models/tag.rb b/app/models/tag.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Tag < ApplicationRecord
   has_many :show_tags, dependent: :destroy
   has_many :shows, through: :show_tags

diff --git a/app/models/tour.rb b/app/models/tour.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Tour < ApplicationRecord
   has_many :shows, dependent: :nullify
 

diff --git a/app/models/track.rb b/app/models/track.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Track < ApplicationRecord
   belongs_to :show
   has_many :songs_tracks, dependent: :destroy

diff --git a/app/models/track_tag.rb b/app/models/track_tag.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class TrackTag < ApplicationRecord
   belongs_to :track, counter_cache: :tags_count
   belongs_to :tag, counter_cache: :tracks_count

diff --git a/app/models/user.rb b/app/models/user.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class User < ApplicationRecord
   has_many :playlists, dependent: :destroy
   has_many :playlist_bookmarks, dependent: :destroy

diff --git a/app/models/venue.rb b/app/models/venue.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class Venue < ApplicationRecord
   has_many :shows, dependent: :nullify
   has_many :venue_renames, dependent: :destroy

diff --git a/app/models/venue_rename.rb b/app/models/venue_rename.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class VenueRename < ApplicationRecord
   belongs_to :venue
 

diff --git a/app/services/date_parser.rb b/app/services/date_parser.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class DateParser
   attr_reader :str, :date_parts
 

diff --git a/app/services/duration_formatter.rb b/app/services/duration_formatter.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class DurationFormatter
   attr_reader :duration, :seconds, :minutes, :hours, :days, :style
 

diff --git a/app/services/google_spreadsheet_fetcher.rb b/app/services/google_spreadsheet_fetcher.rb
@@ -1,8 +1,7 @@
-# frozen_string_literal: true
 class GoogleSpreadsheetFetcher
   attr_reader :spreadsheet_id, :range, :has_headers
 
-  OOB_URI = 'urn:ietf:wg:oauth:2.0:oob'
+  OOB_URI = 'urn:ietf:wg:oauth:2.0:oob'.freeze
   TOKEN_PATH = Rails.root.join('config/google_api.yml')
 
   def initialize(spreadsheet_id, range, opts = {})

diff --git a/app/services/id3_tagger.rb b/app/services/id3_tagger.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 require 'mp3info'
 
 class Id3Tagger

diff --git a/app/services/jamcharts_importer.rb b/app/services/jamcharts_importer.rb
@@ -1,8 +1,7 @@
-# frozen_string_literal: true
 class JamchartsImporter
   include ActionView::Helpers::SanitizeHelper
 
-  BASE_URL = 'https://api.phish.net/v5'
+  BASE_URL = 'https://api.phish.net/v5'.freeze
   API_KEY = ENV.fetch('PNET_API_KEY', nil)
 
   attr_reader :api_key, :invalid_items, :missing_shows, :matched_ids

diff --git a/app/services/mp3_duration_query.rb b/app/services/mp3_duration_query.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 require 'mp3info'
 
 class Mp3DurationQuery

diff --git a/app/services/search_service.rb b/app/services/search_service.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class SearchService
   attr_reader :term
 

diff --git a/app/services/show_importer/cli.rb b/app/services/show_importer/cli.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 require 'readline'
 
 class ShowImporter::Cli

diff --git a/app/services/show_importer/filename_matcher.rb b/app/services/show_importer/filename_matcher.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ShowImporter::FilenameMatcher
   attr_reader :matches, :dir
 

diff --git a/app/services/show_importer/orchestrator.rb b/app/services/show_importer/orchestrator.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 class ShowImporter::Orchestrator
   attr_reader :fm, :date, :show_found, :path, :show_info
 

diff --git a/app/services/show_importer/show_info.rb b/app/services/show_importer/show_info.rb
@@ -1,6 +1,5 @@
-# frozen_string_literal: true
 class ShowImporter::ShowInfo
-  BASE_URL = 'https://api.phish.net/v5'
+  BASE_URL = 'https://api.phish.net/v5'.freeze
   API_KEY = ENV.fetch('PNET_API_KEY', nil)
 
   attr_reader :date, :data, :songs

diff --git a/app/services/show_importer/track_replacer.rb b/app/services/show_importer/track_replacer.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 require 'highline'
 
 class ShowImporter::TrackReplacer

diff --git a/app/services/syncable.rb b/app/services/syncable.rb
@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module Syncable
   private