Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix adding multiple X-Headers in outbound call #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

igorolhovskiy
Copy link
Collaborator

No description provided.

@igorolhovskiy
Copy link
Collaborator Author

@jchavanton
Let me know what you think, but to add, it fixes the issue ONLY on call, not REGISTER

@arsen-semenov-parloa
Copy link

@igorolhovskiy seems does not work on call action, please check screenshot below

[15:25:59.879][INFO] call->test:0xaaaaed660e80 call
[15:25:59.879][INFO] calling :[email protected]
[15:25:59.879][INFO] makeCall Fast-Start: flag:4 PJSUA_CALL_NO_SDP_OFFER:8
[15:25:59.879][INFO] makeCall: Adding custom header X-Test-Header = Bar
15:25:59.879           pjsua_call.c  Making call with acc #1 to sip:[email protected]
15:25:59.879          pjsua_media.c  .Call 0: initializing media..
15:25:59.879          pjsua_media.c  ..RTP socket reachable at 172.16.238.24:4000
15:25:59.879          pjsua_media.c  ..RTCP socket reachable at 172.16.238.24:4001
15:25:59.879          pjsua_media.c  ..Media index 0 selected for audio call 0
15:25:59.879           pjsua_core.c  ....TX 906 bytes Request msg INVITE/cseq=1703 (tdta0xaaaaed66a668) to UDP 72.16.238.20:5060:
INVITE sip:[email protected] SIP/2.0
Via: SIP/2.0/UDP 172.16.238.24:5060;rport;branch=z9hG4bKPjb9b108a8-3556-42dd-9577-94d7c3a80cee
Max-Forwards: 70
From: <sip:[email protected]>;tag=485c05f0-76bf-4b63-a3db-d762aca209f1
To: sip:[email protected]
Contact: <sip:[email protected]:5060;ob>
Call-ID: 13c13f91-285d-4587-8c35-2dd5fdfa4339
CSeq: 1703 INVITE
Allow: PRACK, INVITE, ACK, BYE, CANCEL, UPDATE, INFO, SUBSCRIBE, NOTIFY, REFER, MESSAGE, OPTIONS
Supported: replaces, 100rel, norefersub
Content-Type: application/sdp
Content-Length:   343

v=0
o=- 3931428359 3931428359 IN IP4 172.16.238.24
s=pjmedia
b=AS:84
t=0 0
a=X-nat:0
m=audio 4000 RTP/AVP 8 0 120
c=IN IP4 172.16.238.24
b=TIAS:64000
a=rtcp:4001 IN IP4 172.16.238.24
a=sendrecv
a=rtpmap:8 PCMA/8000
a=rtpmap:0 PCMU/8000
a=rtpmap:120 telephone-event/8000
a=fmtp:120 0-16
a=ssrc:1793836422 cname:476a5aee4886be47

@igorolhovskiy
Copy link
Collaborator Author

Hm... I'll check with a provided pjproject version. I'm using a newer one...

@igorolhovskiy
Copy link
Collaborator Author

@arsen-semenov-parloa
Can you pls check with recent commit?

@arsen-semenov-parloa
Copy link

@igorolhovskiy do you mean that this PR should be tried with this fork of pjproject and this commit: d8fefe6cbaa ?

I got it worked with this master branch of this fork

@igorolhovskiy
Copy link
Collaborator Author

Ok. Than I'll let @jchavanton decide if he wants to update pjproject to a recent one.

@arsen-semenov-parloa
Copy link

thanks for keeping this project up!

@jchavanton
Copy link
Owner

@igorolhovskiy I am in favor of updating to latest pjproject, you may include it in this MR.

Cheers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants