stop polyfill initialising if there are no date inputs on the page or… #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jcgertig - Loving this polyfill, but noticed that it initialises itself (including dependencies) even if there aren't any input:date on the page, or even if the browser supports it's own datepicker that overrides the polyfill. So this fixes that (if you like it) - it can save maybe 50ms on a modern PC, but can save a lot more on slower phones that would never use it anyway (most versions of android/iOS support native pickers).
Attached are flamecharts of how the existing version looks in Chrome 58 (which supports datepicker and overrides the polyfill anyway), how it looks when it detects browsers that support datepickers, and how it looks when there aren't any date inputs on the page. (ignore the time to load localhost HTML, webpack server is a bit inconsistent with load times!).
Hope it's ok to submit a PR!