#36 Log exception when unable to read from underlying stream

jcabi · Oct 21, 2014 · aef7042 · aef7042
1 parent 814ea7b
commit aef7042
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/main/java/com/jcabi/log/VerboseProcess.java b/src/main/java/com/jcabi/log/VerboseProcess.java
@@ -365,6 +365,12 @@ public Void call() throws Exception {
                         writer.write(line);
                         writer.newLine();
                     }
+                } catch (final IOException ex) {
+                    Logger.error(
+                        VerboseProcess.class,
+                        "Error reading from process stream: %[exception]s",
+                        ex
+                    );
                 } finally {
                     VerboseProcess.close(writer);
                     this.done.countDown();

diff --git a/src/test/java/com/jcabi/log/VerboseProcessTest.java b/src/test/java/com/jcabi/log/VerboseProcessTest.java
@@ -212,7 +212,7 @@ public void stdoutQuietlyLogsErrors() throws Exception {
     /**
      * VerboseProcess exits "gracefully" when it can't read from the process
      * stream, and logs the error that is thrown.
-     * @throws Exception
+     * @throws Exception If something goes wrong
      */
     @Test
     public void logsErrorWhenUnderlyingStreamIsClosed() throws Exception {
@@ -231,9 +231,7 @@ public void logsErrorWhenUnderlyingStreamIsClosed() throws Exception {
         new VerboseProcess(prc, Level.ALL, Level.ALL).stdout();
         MatcherAssert.assertThat(
             writer.toString(),
-            Matchers.containsString("underlying process stream was closed")
+            Matchers.containsString("Error reading from process stream")
         );
     }
-
 }
-;