Add modreq and modopt to imported FieldRefs #921
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a FieldReference using the DefaultReflectionImporter, the volatile modifier was lost. This resulted in a
System.MissingFieldException at runtime if one wanted to access such field via Cecil emitted IL. The bare type was used for the field, excluding the modreq IsVolatile modifier.
This commit wraps the field's type into RequiredModifierType and OptionalModifierType objects, this way the writer emits correct IL for the volatile field reference.
I hope my commit message is clear in what the problem was, and what my solution is. It definitely needs a test, which I am unsure of where to put. I only found one method calling
ModuleDefinition.ImportReference(FieldInfo)
and that deals with generics.I've tested my code with a
static volatile bool[]
field in a C# library. I don't know any other modreq at the moment, and I think modopt is only used for C++. I am also not sure how multiple modreq and modopt should be handled (or where do I even encounter them), in what order.I am new to Cecil, so my code might be janky a bit, but I'm open to suggestions. I didn't want to just open an issue and wait for someone to fix it, I've tried, and it works for me, treat it as an MVC.