Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for 64-bit systems and -m argument for chaser delay #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Minor fixes for 64-bit systems and -m argument for chaser delay #19

wants to merge 4 commits into from

Conversation

0tobsam0
Copy link

  • created switch for 32-bit and 64-bit pointer type (uint32_t and size_t)
  • added command line argument for chaser delay

@0tobsam0
Fixes for RPi 4
eeaf849 
- use "gcc -Wall -fcommon -o rpi_pixleds rpi_pixleds.c rpi_dma_utils.c" to compile
@0tobsam0
turned chaser test delay into a command line argument
9fa8c8d
@0tobsam0
fixed multiple definition of "clk_regs"
104ff14
@0tobsam0
Tried building a .so library
884f77f 
- build with "gcc -Wall -fPIC -shared -o rpi_pixleds.so rpi_pixleds_lib.c rpi_dma_utils.c"
dolby360
dolby360 reviewed Mar 3, 2024
View reviewed changes
rpi_pixleds.so
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure you need this ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. A code repo is not the place for binaries.

@petiepooo
Copy link

Thank you for the PR. I like some of the changes, but it needs some work first IMO.

Does the library work? The commit message isn't very clear.

You may have better luck breaking this into individual PRs per feature.

@mouqurem
Copy link

Did all the stuff to convert into 64bit but I still have a segmentation fault when I run rpi_dma_test. Any help :) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolby360 dolby360 dolby360 left review comments

@petiepooo petiepooo petiepooo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0tobsam0 @petiepooo @mouqurem @dolby360