Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer arugments for Plugin.finish from view_func (update_listing e.g.) #91

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

transfer arugments for Plugin.finish from view_func (update_listing e.g.) #91

wants to merge 1 commit into from

Conversation

fanatid
Copy link

@fanatid fanatid commented Feb 8, 2013

Right now if you want set update_listing as True, you need write about the following:

plugin.finish(items=items, update_listing=True)
plugin._end_of_directory = True

This patch allow return dict from view_func and passes this dict to plugin.finish in plugin._dispatch. Also allows return Iterable value, it's passed as items.

@tamland
Copy link

tamland commented Feb 8, 2013

I think that's pretty much what I did in #84, except for the dict check..

@jbeluch
Copy link
Owner

jbeluch commented Feb 8, 2013

This is interesting. Always wanted a way to be able to pass the plugin.finish() args in a simple response object without having to call plugin.finish() explicitly. Adding this optional extra layer would certainly solve that...

@ghost ghost assigned jbeluch Feb 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants