Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable SimdOps.assembleAndSum; implement Panama/Native equivalent for CosineDecoder acceleration #368

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Reenable SimdOps.assembleAndSum; implement Panama/Native equivalent for CosineDecoder acceleration #368

merged 7 commits into from
Nov 22, 2024

Conversation

michaeljmarshall
Copy link
Contributor

Fixes: #367

@michaeljmarshall michaeljmarshall force-pushed the wip-cosine-decoder branch 2 times, most recently from b43d85c to 83590f0 Compare November 14, 2024 22:17
@jkni jkni self-requested a review November 18, 2024 23:52
@jkni
Copy link
Collaborator

jkni commented Nov 19, 2024

This looks reasonable to me in implementing what I described in the linked issue. Basic performance testing shows the anticipated improvements for Panama/Native cosine and Panama dot product.

@marianotepper can you also take a review pass here and see if it makes sense to you? Interested in your input and also looking for a second review since I did contribute some commits to this PR.

marianotepper
marianotepper reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

My only suggestion would be to use a more descriptive name than decodedCosineSimilarity. Given that we are light on documentation, I would at least use a name like pqDecodedCosineSimilarity to give it some context.

@michaeljmarshall
Copy link
Contributor Author

@marianotepper thanks for your review. I prefixed (and fixed casing) on all decodedCosineSimilarity and decoded_cosine_similarity method names with pq and pq_ respectively.

@michaeljmarshall michaeljmarshall mentioned this pull request Nov 21, 2024
Open
jkni
jkni approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jkni jkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the name change.

@marianotepper
Copy link
Collaborator

LGTM

@jbellis jbellis merged commit da08d40 into jbellis:main Nov 22, 2024
6 checks passed
@michaeljmarshall michaeljmarshall deleted the wip-cosine-decoder branch November 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianotepper marianotepper marianotepper left review comments

@jkni jkni jkni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reenable usage of SimdOps.assembleAndSum. Implement Panama/Native equivalent for CosineDecoder acceleration
4 participants
@michaeljmarshall @jkni @marianotepper @jbellis