-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Python 3.13 #756
base: master
Are you sure you want to change the base?
Conversation
|
@ulgens do not forget to add the classifier for python 3.13 to |
@WisdomPill I was just checking |
@@ -60,9 +61,10 @@ envlist = | |||
# tests against released versions | |||
py{38,39}-dj{42}-redislatest | |||
py{310,311,312}-dj{42,50,51}-redislatest | |||
py313-dj51-redislatest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not do like on line 67?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line aims to add Python 3.13 (supported only by Django 5.1) and the latest Redis to the matrix. Not sure how it can be more like line 67, an example would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
py313-dj51-redislatest | |
py313-dj51-redis{latest,master} |
and remove py313-dj51-redismaster
from line 66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. I can apply that, but there is contextual grouping between tests against released versions
and tests against unreleased versions
in that block. Do we want to change that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python3.13
is not yet supported by redis-py
officially so I guess we can consider it unreleased 😄
It's in place right now. Thank for the reminder. |
@vladvildanov I think this is you now. |
No description provided.