Disable admin interface from settings.py #643
Open
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramezani
reviewed
May 16, 2024
| @@ -57,3 +57,7 @@ def has_delete_permission(self, request, obj=None): | |||
| def get_queryset(self, request): | |||
| self.request = request | |||
| return super().get_queryset(request=request) | |||
|
|
|||
|
|
|||
| if not settings.AUDITLOG_DISABLE_ADMIN_INTERFACE: | |||
There was a problem hiding this comment.
please change the settings name to AUDITLOG_ENABLE_ADMIN_INTERFACE with default value of True
hramezani
reviewed
May 16, 2024
| @@ -463,3 +463,10 @@ Django Admin integration | |||
|
|
|||
| When ``auditlog`` is added to your ``INSTALLED_APPS`` setting a customized admin class is active providing an enhanced | |||
| Django Admin interface for log entries. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please add .. versionadded:: 3.1.0
|
Thanks @gferrate for this PR. I left some comments. Please add a test and also changelog into https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 95.21% 95.29% +0.07%
==========================================
Files 31 31
Lines 1025 1042 +17
==========================================
+ Hits 976 993 +17
Misses 49 49 ☔ View full report in Codecov by Sentry. |
gferrate
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables admin interface by adding
AUDITLOG_DISABLE_ADMIN_INTERFACE = Falsein settings.py