[better_errors] Refactor more uses of pe.tracing_debug_info (part 3) #26100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
debug_info_no_pe_debug_info_3
branch
2 times, most recently
from
4c3bbcf to
75584c3
Compare
gnecula
changed the title
… (part 1) We replace those uses with api_util.tracing_debug_info, which means we have to move the call further upstream. But this is better because we have the actual args and kwargs, and we can do a better job, especially for `arg_names`. This is part 1 of a series, for: cond, switch, while, scan, composite, custom_dce, custom_root, custom_linear_solve, saved_residuals.
We replace uses of `pe.tracing_debug_info` with with `api_util.tracing_debug_info`, which uses the actual args and kwargs, instead of `in_tree` to manufacture fake args and kwargs. This ends up being more accurate, especially for `arg_names`; see changes in debug_info_tests.py. This means that we have to construct the debug info further upstream, before flattening args. This will later help populate debug info in `WrappedFun` and `Jaxpr`. This is part 2 of a series (following jax-ml#26097) for Pallas.
We replace uses of `pe.tracing_debug_info` with with `api_util.tracing_debug_info`, which uses the actual args and kwargs, instead of `in_tree` to manufacture fake args and kwargs. This ends up being more accurate, especially for `arg_names`; see changes in debug_info_tests.py. This means that we have to construct the debug info further upstream, before flattening args. This will later help populate debug info in `WrappedFun` and `Jaxpr`. This is part 3 of a series (following jax-ml#26097, jax-ml#26099) for jit, pmap, checkify, custom_dce.
gnecula
force-pushed
the
debug_info_no_pe_debug_info_3
branch
from
75584c3 to
b702f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We replace uses of
pe.tracing_debug_infowith withapi_util.tracing_debug_info,which uses the actual args and kwargs, instead of
in_treeto manufacture fakeargs and kwargs. This ends up being more accurate, especially for
arg_names;see changes in debug_info_tests.py.
This means that we have to construct the debug info further upstream, before
flattening args. This will later help populate debug info in
WrappedFunandJaxpr.This is part 3 of a series (following #26097, #26099) for jit, checkify, custom_dce.