This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
More finegrained error messages to support reading from named pipes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense, are you actively using this project? |
|
Yeah it is being used in a daemon interfacing between snort and some internal tooling. Thanks for publishing the code. Let me know if you have some thoughts on how to improve the proposed changes, more than happy to implement that and get this upstream :) |
|
Any interest in taking this over? I haven't written Go in about 2 years, and don't think I even having a working toolchain installed anywhere right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the pull request make it easier to read from named pipes which do not allow to seek. Whatever the read returns from the named-pipe needs to be buffered. The more fine-grained error messages can be useful as follows:
ErrBufferTooSmall (n)- wait fornmore bytes to arrive, retry parsingErrInvalidHeader- advance file pointer by 1 position and retry parsing header there (useful to find beginning of record)ErrMalformedRecord- skip the whole recordThis enables to process records instantly by waiting for just enough bytes to become available, reopen a u2 named pipe mid-record and skipping bad-records.